Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

> > On Thursday 11 September 2008 16:55:18 Aaron J. Seigo wrote: > > On Thursday 11 September 2008, Dario Freddi wrote: > > > Discussed on IRC and agreed only to return when reply is not valid, > > > included in the patch > > > > please be sure to add this to kdebase/workspace/plasma/design/CHAN

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

On Thursday 11 September 2008 16:55:18 Aaron J. Seigo wrote: > On Thursday 11 September 2008, Dario Freddi wrote: > > Discussed on IRC and agreed only to return when reply is not valid, > > included in the patch > > please be sure to add this to kdebase/workspace/plasma/design/CHANGELOG =) > > th

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

On Thursday 11 September 2008, Dario Freddi wrote: > Discussed on IRC and agreed only to return when reply is not valid, > included in the patch please be sure to add this to kdebase/workspace/plasma/design/CHANGELOG =) thanks for working on this ... great stuff. -- Aaron J. Seigo humru othro a

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

> On 2008-09-11 06:54:27, Sebastian Kügler wrote: > > Other than my comments, it looks good to me, though I wouldn't mind someone > > else having another look at it ... > > Alessandro Diaferia wrote: > the patch looks good to me too. just remove the whitespaces (highlighted > in red here).

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

> On 2008-09-11 06:54:27, Sebastian Kügler wrote: > > Other than my comments, it looks good to me, though I wouldn't mind someone > > else having another look at it ... the patch looks good to me too. just remove the whitespaces (highlighted in red here). =) - Alessandro --

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

> On 2008-09-11 06:54:27, Sebastian Kügler wrote: > > /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp, > > line 70 > > > > > > We can return here already, as the rest of the code

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/188/ --- (Updated 2008-09-11 07:08:52.151574) Review request for Plasma. Summary -

Re: Review Request: Merging PowerDevil engine with base/powermanagementengine

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/188/#review182 --- Ship it! Other than my comments, it looks good to me, though I wo

Review Request: Merging PowerDevil engine with base/powermanagementengine

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/188/ --- Review request for Plasma. Summary --- As agreed on IRC with sebas, I'