Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18474 --- This review has been submitted with commit c44cff20fdf0b2dff83

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18465 --- Ship it! ok for me with ColumnProxyModel and to push - Marco

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- (Updated Sept. 3, 2012, 4:46 p.m.) Review request for Plasma, Aurélien Gât

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aurélien Gâteau
> On Aug. 30, 2012, 12:17 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.h, line 25 > > > > > > I don't like the "FullModelAccess" name. It is a model, so to avoid > > c

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aleix Pol Gonzalez
> On Aug. 30, 2012, 12:17 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.h, line 25 > > > > > > I don't like the "FullModelAccess" name. It is a model, so to avoid > > c

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aurélien Gâteau
> On Aug. 31, 2012, 3:48 p.m., Aleix Pol Gonzalez wrote: > > I think the only important thing left is the name... Nobody has a good idea? > > > > SimplifierProxyModel? ListProxyModel? Damn, forgot to hit "publish" on some of my friday comments. See latest comment above. - Aurélien

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aurélien Gâteau
> On Aug. 30, 2012, 12:17 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.h, line 25 > > > > > > I don't like the "FullModelAccess" name. It is a model, so to avoid > > c

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18334 --- I think the only important thing left is the name... Nobody has

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- (Updated Aug. 31, 2012, 3:45 p.m.) Review request for Plasma, Aurélien Gât

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
> On Aug. 31, 2012, 1:18 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.cpp, line 123 > > > > > > I am actually wondering if hitting this condition is really weird: >

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18325 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.cp

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
> On Aug. 30, 2012, 12:17 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.h, line 25 > > > > > > I don't like the "FullModelAccess" name. It is a model, so to avoid > > c

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- (Updated Aug. 31, 2012, 7:53 a.m.) Review request for Plasma, Aurélien Gât

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
> On Aug. 30, 2012, 12:17 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.h, line 25 > > > > > > I don't like the "FullModelAccess" name. It is a model, so to avoid > > c

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18278 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.h

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18276 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.cp

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18274 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.h

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- (Updated Aug. 30, 2012, 10:43 a.m.) Review request for Plasma, Aurélien Gâ

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
> On Aug. 30, 2012, 8:34 a.m., Marco Martin wrote: > > while it may be useful being able to access other columns, being able to > > specify the root index duplicates the standard > > http://qt-project.org/doc/qt-4.8/qml-visualdatamodel.html > > > > not sure it is possible combining them tough.

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18269 --- while it may be useful being able to access other columns, bein

Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- Review request for Plasma, Aurélien Gâteau and Marco Martin. Description -