Re: Review Request: Make DBusMenuQt optional

2011-02-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4898/#review9913 --- Ship it! what's the status of this patch for KDE 4.6? it makes c

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Marc Mutz
> On 2010-08-06 07:10:08, Aaron Seigo wrote: > > personally, i'm fine with the patch, if only for correctness in terms of > > "as few hard requirements as possible." > > > > in practice, i find the usefulness of the patch to be dubious, but it can't > > hurt to at least allow it to be optional

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Aaron Seigo
> On 2010-08-04 16:08:34, Aurélien Gâteau wrote: > > The change looks OK, but I am wondering why you do not want to link with > > DBusMenuQt. Having (very) different code paths is potentially a source of > > trouble for maintenance. > > Marc Mutz wrote: > Having that kind of library as a h

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Aaron Seigo
> On 2010-08-06 07:10:08, Aaron Seigo wrote: > > personally, i'm fine with the patch, if only for correctness in terms of > > "as few hard requirements as possible." > > > > in practice, i find the usefulness of the patch to be dubious, but it can't > > hurt to at least allow it to be optional

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Ingo Klöcker
> On 2010-08-06 07:10:08, Aaron Seigo wrote: > > personally, i'm fine with the patch, if only for correctness in terms of > > "as few hard requirements as possible." > > > > in practice, i find the usefulness of the patch to be dubious, but it can't > > hurt to at least allow it to be optional

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Aaron Seigo
> On 2010-08-04 16:08:34, Aurélien Gâteau wrote: > > The change looks OK, but I am wondering why you do not want to link with > > DBusMenuQt. Having (very) different code paths is potentially a source of > > trouble for maintenance. > > Marc Mutz wrote: > Having that kind of library as a h

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4898/#review6836 --- did you try if besides compiling the menus still show up correctly? as

Re: Review Request: Make DBusMenuQt optional

2010-08-06 Thread Marc Mutz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4898/ --- (Updated 2010-08-06 12:34:16.273483) Review request for kdelibs, Plasma and Marc