Re: Review Request: Launchersupport in libtaskmanager - final implementation

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5785/#review8674 --- Ship it! let's try for it... - Marco On 2010-11-11 20:52:31, A

Re: Review Request: Launchersupport in libtaskmanager - final implementation

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5785/ --- (Updated 2010-11-11 20:52:31.230598) Review request for Plasma. Changes --

Re: Review Request: Launchersupport in libtaskmanager - final implementation

> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp, line 316 > > > > > > the fact that his can fail hints that this is a feature in the wrong > > place. > >

Re: Review Request: Launchersupport in libtaskmanager - final implementation

> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp, lines 305-312 > > > > > > why "Pin Task"? that doesn't really tell me what it does at all. what > > it re

Re: Review Request: Launchersupport in libtaskmanager - final implementation

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5785/ --- (Updated 2010-11-09 20:17:52.753948) Review request for Plasma. Changes --

Re: Review Request: Launchersupport in libtaskmanager - final implementation

> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp, line 607 > > > > > > as this is only used from the context menu action, this should be moved > > there.

Re: Review Request: Launchersupport in libtaskmanager - final implementation

> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h, lines 129-147 > > > > > > with these changes, GroupManager gets a lot of API for launchers. > > similar AP

Re: Review Request: Launchersupport in libtaskmanager - final implementation

> On 2010-11-07 18:07:13, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h, lines 129-147 > > > > > > with these changes, GroupManager gets a lot of API for launchers. > > similar AP

Re: Review Request: Launchersupport in libtaskmanager - final implementation

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5785/#review8541 --- trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h

Re: Review Request: Launchersupport in libtaskmanager - final implementation

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5785/ --- (Updated 2010-11-07 13:19:14.069931) Review request for Plasma. Summary --

Review Request: Launchersupport in libtaskmanager - final implementation

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5785/ --- Review request for Plasma. Summary --- This is the final implementation