Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 9:36 p.m., Marco Martin wrote: > > Oh yeah :) Thanx! - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 -

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7850 --- This review has been submitted with commit 5729cc5ababdb4d7a54b

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 --- Ship it! - Marco Martin On Nov. 1, 2011, 9:20 p.m., Mark Gais

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- (Updated Nov. 1, 2011, 9:20 p.m.) Review request for KDE Runtime, Plasma a

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7842 --- well done, getting near :) only last thing: could you make it us

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- (Updated Nov. 1, 2011, 8:52 p.m.) Review request for KDE Runtime, Plasma a

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 7:20 p.m., Marco Martin wrote: > > plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 60 > > > > > > width of the buttons should always be the same unless explicitly > > resized by th

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7830 --- i like the effect of having an animated press effect. this comes

Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- Review request for KDE Runtime, Plasma and Marco Martin. Description -