Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/ --- (Updated Oct. 22, 2012, 6:51 p.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/#review20690 --- Since 4.9 it is possible to use special property windowId of o

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
> On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 > > > > > > Can you make the size honour the global KDE icon size settings? This

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
> On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 > > > > > > Can you make the size honour the global KDE icon size settings? This

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Marco Martin
> On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 > > > > > > Can you make the size honour the global KDE icon size settings? This

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Kai Uwe Broulik
> On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 > > > > > > Can you make the size honour the global KDE icon size settings? This

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
> On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote: > > plasma/generic/applets/systemtray/ui/wheelarea.h, line 1 > > > > > > this implementation is not necessary, a wheelevent was added in > > org.kde.qtextracomponen

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
> On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 > > > > > > Can you make the size honour the global KDE icon size settings? This

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/#review20657 --- Ship it! to me is good to go :) - Marco Martin On Oct. 22,

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Marco Martin
> On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote: > > plasma/generic/applets/systemtray/ui/wheelarea.h, line 1 > > > > > > this implementation is not necessary, a wheelevent was added in > > org.kde.qtextracomponen

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
> On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote: > > plasma/generic/applets/systemtray/ui/wheelarea.h, line 1 > > > > > > this implementation is not necessary, a wheelevent was added in > > org.kde.qtextracomponen

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/ --- (Updated Oct. 22, 2012, 9:19 a.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/ --- (Updated Oct. 22, 2012, 9:03 a.m.) Review request for Plasma, Aaron J. Sei