Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/#review4864 --- This review has been submitted with commit 7e8675b11baedc95eb38

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/#review4782 --- This review has been submitted with commit 848f7d43fd9a9b029d2a

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Alex Fiestas
> On July 17, 2011, 7:49 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/ui/stackdialog.cpp, lines 298-299 > > > > > > these could be merged into one if () statement. I prefer small conditional

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/#review4776 --- Ship it! looks good. one small note on a possible improvement f

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/ --- (Updated July 17, 2011, 6:49 p.m.) Review request for Plasma. Changes --

Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/ --- Review request for Plasma. Summary --- On resizeEvent adjustPosition