Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-06 Thread Shantanu Tushar Jha
On Fri, Jul 3, 2009 at 7:11 PM, Sebastian Kügler wrote: > On Friday 03 July 2009 07:06:17 Shantanu Tushar Jha wrote: >> bool invalidPicture = (m_currentUrl.path() == "Default") && >> (m_mySlideShow->currentUrl() == "Default"); if >> (hasAuthorization("LaunchApp") && ! (m_menuPresent || m_potd || >>

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-04 Thread Sebastian Kügler
On Friday 03 July 2009 07:06:17 Shantanu Tushar Jha wrote: > bool invalidPicture = (m_currentUrl.path() == "Default") && > (m_mySlideShow->currentUrl() == "Default"); if > (hasAuthorization("LaunchApp") && ! (m_menuPresent || m_potd || > invalidPicture)) { I can't see you patch, but this line smel

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Aaron Seigo
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/926/#review1442 --- trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/926/#review1439 --- Ship it! - Aaron On 2009-07-02 09:15:41, Shantanu Tushar Jha wrote:

Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/926/ --- Review request for Plasma. Summary --- Picture Frame didn't have Open Pictur