Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 9, 2013, 2 a.m.) Review request for kdelibs, kwin, Plasma, A

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 9, 2013, 12:52 a.m.) Review request for kdelibs, kwin, Plasm

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 9, 2013, 1:38 a.m., Xuetian Weng wrote: > > kdeui/windowmanagement/kwindowsystem_x11.cpp, line 168 > > > > > > I don't quite get why this part is required. Since KWindowSystem > > already calls SelectSe

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25025 --- kdeui/windowmanagement/kwindowsystem_x11.cpp

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25012 --- after I apply the patch, I notice that in some random unknnow c

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > > > Thomas Lübking wrote: > Ok, probl

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > > > Thomas Lübking wrote: > Ok, probl

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Fredrik Höglund
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > > > Thomas Lübking wrote: > Ok, probl

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 5, 2013, 5:08 p.m.) Review request for kdelibs, kwin, Plasma