Re: Review Request: Emit signal when launchQuery finish

2010-01-15 Thread Aaron Seigo
> On 2010-01-15 22:51:19, Aaron Seigo wrote: > > small name change to the signal, otherwise looks good. oops, forgot: it needs an @since to it (4.4 if it is going to be backported to the branch, which would have to happen prior t 4.4.0 being released if it is going to be backported, otherwise

Re: Review Request: Emit signal when launchQuery finish

2010-01-15 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2592/#review3718 --- Ship it! small name change to the signal, otherwise looks good. tru

Review Request: Emit signal when launchQuery finish

2010-01-14 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2592/ --- Review request for Plasma and Aaron Seigo. Summary --- Right now when we us