Re: Review Request: Center tool tips in Plasma

2009-09-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/#review2486 --- Ship it! :) - Aaron On 2009-09-27 13:18:54, Michal Dutkiewicz wrot

Re: Review Request: Center tool tips in Plasma

2009-09-27 Thread Marco Martin
> On 2009-08-28 21:42:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 > > > > > > i thought we were going to avoid the bool and instead use Qt::Alignment? > > wrote: > So only one public me

Re: Review Request: Center tool tips in Plasma

2009-09-27 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/ --- (Updated 2009-09-27 13:18:54.556459) Review request for Plasma and Aaron Seigo.

Re: Review Request: Center tool tips in Plasma

2009-08-29 Thread Aaron J. Seigo
On August 29, 2009, Emdek wrote: > On 29-08-2009 at 13:48:31 Aaron J. Seigo wrote: > > On August 29, 2009, Emdek wrote: > >> For me there should be option only to center (useful for tool tips and > >> at > >> least some popups) or to use current behavior (menus). > > > > there are likely times tha

Re: Review Request: Center tool tips in Plasma

2009-08-29 Thread Emdek
On 29-08-2009 at 13:48:31 Aaron J. Seigo wrote: > On August 29, 2009, Emdek wrote: >> For me there should be option only to center (useful for tool tips and >> at >> least some popups) or to use current behavior (menus). > > there are likely times that right aligned will be desired, and it > p

Re: Review Request: Center tool tips in Plasma

2009-08-29 Thread Aaron J. Seigo
On August 29, 2009, Emdek wrote: > On 29-08-2009 at 13:06:20 Aaron J. Seigo wrote: > > On August 29, 2009, Michal Dutkiewicz wrote: > >> > On 2009-08-28 21:42:20, Aaron Seigo wrote: > >> > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 > >> > >>

Re: Review Request: Center tool tips in Plasma

2009-08-29 Thread Emdek
On 29-08-2009 at 13:06:20 Aaron J. Seigo wrote: > On August 29, 2009, Michal Dutkiewicz wrote: >> > On 2009-08-28 21:42:20, Aaron Seigo wrote: >> > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 >> > > >> >> > > >> > >

Re: Review Request: Center tool tips in Plasma

2009-08-29 Thread Aaron J. Seigo
On August 29, 2009, Michal Dutkiewicz wrote: > > On 2009-08-28 21:42:20, Aaron Seigo wrote: > > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 > > > > > > > > > i thought we were going to avoid the bool and instead use >

Re: Review Request: Center tool tips in Plasma

2009-08-29 Thread Michal Dutkiewicz
> On 2009-08-28 21:42:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 > > > > > > i thought we were going to avoid the bool and instead use Qt::Alignment? So only one public method with optional

Re: Review Request: Center tool tips in Plasma

2009-08-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/#review2173 --- /trunk/KDE/kdelibs/plasma/corona.h

Review Request: Center tool tips in Plasma

2009-08-28 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch aims to p