Re: Review Request: Add support for custom package metadata

2008-11-02 Thread Petri Damstén
> On 2008-11-02 03:33:56, Aaron Seigo wrote: > > a little bit of cleanup needed yet, but generally ready to go in. > > > > not sure what your use case was, though this is obviously useful (there was > > even a comment in there about it =) > > So plasmapkg can get pluginName for package and uni

Re: Review Request: Add support for custom package metadata

2008-11-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/248/#review242 --- Ship it! a little bit of cleanup needed yet, but generally ready

Re: Review Request: Add support for custom package metadata

2008-11-02 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/248/ --- (Updated 2008-11-02 03:11:18.139608) Review request for Plasma. Summary -

Re: Review Request: Add support for custom package metadata

2008-11-02 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/248/ --- (Updated 2008-11-02 02:35:10.067208) Review request for Plasma. Summary -

Re: Review Request: Add support for custom package metadata

2008-11-01 Thread Aaron Seigo
> On 2008-11-01 14:04:42, Aaron Seigo wrote: > > the PackageMetadata class is really just a wrapper around a bunch of > > QStrings. i think it makes sense to change Plasma::Package to return a > > Plasma::PackageMetadata rather than a Plasma::PackageMetadata* and add a > > copy ctor to Package

Re: Review Request: Add support for custom package metadata

2008-11-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/248/#review240 --- the PackageMetadata class is really just a wrapper around a bunch

Review Request: Add support for custom package metadata

2008-10-31 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/248/ --- Review request for Plasma. Summary --- This adds support for custom pa