Re: Review Request: Add next and previous buttons to Frame applet

2009-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1028/#review1833 --- Ship it! Patch looks fine, other than some minor coding style things,

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-28 Thread Arthur Mello
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1028/ --- (Updated 2009-07-28 20:22:17.663566) Review request for Plasma. Changes --

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-18 Thread Sebastian Kügler
On Friday 17 July 2009 23:06:56 Sebastian Kügler wrote: > On Friday 17 July 2009 18:25:06 Arthur Renato Mello wrote: > > On Fri, Jul 17, 2009 at 9:10 AM, Sebastian Kügler wrote: > > > However, I have rather substantial changes to the frame applet on my > > > disk. I'm resolving some issues that I w

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-17 Thread Sebastian Kügler
On Friday 17 July 2009 18:25:06 Arthur Renato Mello wrote: > On Fri, Jul 17, 2009 at 9:10 AM, Sebastian Kügler wrote: > > However, I have rather substantial changes to the frame applet on my > > disk. I'm resolving some issues that I wouldn't like to see committed > > this weekend and am planning t

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-17 Thread Arthur Renato Mello
On Fri, Jul 17, 2009 at 9:10 AM, Sebastian Kügler wrote: > However, I have rather substantial changes to the frame applet on my disk. I'm > resolving some issues that I wouldn't like to see committed this weekend and > am planning to commit the whole thing this weekend. It would be good if I > didn

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-17 Thread Sebastian Kügler
On Tuesday 14 July 2009 19:36:08 Arthur Mello wrote: > As mentioned on Frame TODO this patch adds buttons to navigate through > slide show. Buttons appear when mouse is over applet and only when applet > is doing a slideshow. Example code at TODO put the buttons above the > pictue, I placed them on

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-14 Thread Anne-Marie Mahfouf
> On 2009-07-14 21:04:59, Anne-Marie Mahfouf wrote: > > Works well and I don't see anything wrong in code on a quick look. Sebas, > > can you take a quick look as you'll add remote URL support? > > Thanks Arthur for this patch! > > A pause button was also in the wish list... ;) Referring to htt

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-14 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1028/#review1601 --- Works well and I don't see anything wrong in code on a quick look. Seb

Review Request: Add next and previous buttons to Frame applet

2009-07-14 Thread Arthur Mello
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1028/ --- Review request for Plasma. Summary --- As mentioned on Frame TODO this patc