Re: Review Request: Add context menu to classic style Kickoff menu

2009-03-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/377/#review549 --- Ship it! - Aaron On 2009-03-21 11:51:38, Christian Loose wrote: > >

Re: Review Request: Add context menu to classic style Kickoff menu

2009-03-21 Thread Christian Loose
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/377/ --- (Updated 2009-03-21 11:51:38.095921) Review request for Plasma. Changes ---

Re: Review Request: Add context menu to classic style Kickoff menu

2009-03-21 Thread Christian Loose
> On 2009-03-21 10:09:28, Aaron Seigo wrote: > > the concept is good, however the two showContextMenu methods in > > ContextMenuFactory should be harmonized. both produce a QModelIndex and > > then from that point forward it looks like the code is pretty much > > duplicated between the two. >

Re: Review Request: Add context menu to classic style Kickoff menu

2009-03-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/377/#review547 --- the concept is good, however the two showContextMenu methods in Context

Review Request: Add context menu to classic style Kickoff menu

2009-03-21 Thread Christian Loose
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/377/ --- Review request for Plasma. Summary --- This patch adds the kickoff context m