Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-10-05 Thread John Layt
On Monday 04 October 2010 20:31:36 John Layt wrote: > On Saturday 25 September 2010 19:44:09 you wrote: > > On Saturday, September 25, 2010, you wrote: > > > However, we really need to sort > > > out geolocation services for KDE as a whole, re-inventing everything > > > that Geoclue and Marble have

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-10-04 Thread John Layt
On Saturday 25 September 2010 19:44:09 you wrote: > On Saturday, September 25, 2010, you wrote: > > I do have a GPS, I could try get it working to test the patch if there is > > still interest in getting this in. However, we really need to sort out > > geolocation services for KDE as a whole, re-i

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-09-25 Thread John Layt
> On 2009-04-14 18:59:59, Aaron Seigo wrote: > > other than a couple of code style comments, and that i can't test it with a > > gps for you either :/, my only question/concern is that it's doing look ups > > on the internet without checking to see if we're connected. it could be in > > a loca

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-09-24 Thread Beat Wolf
> On 2009-04-14 18:59:59, Aaron Seigo wrote: > > other than a couple of code style comments, and that i can't test it with a > > gps for you either :/, my only question/concern is that it's doing look ups > > on the internet without checking to see if we're connected. it could be in > > a loca

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-01-27 Thread Petri Damstén
On Sunday 24 January 2010 17:18:49 Beat Wolf wrote: > > On 2009-04-14 18:59:59, Aaron Seigo wrote: > > > other than a couple of code style comments, and that i can't test it > > > with a gps for you either :/, my only question/concern is that it's > > > doing look ups on the internet without checki

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-01-24 Thread Beat Wolf
> On 2009-04-14 18:59:59, Aaron Seigo wrote: > > other than a couple of code style comments, and that i can't test it with a > > gps for you either :/, my only question/concern is that it's doing look ups > > on the internet without checking to see if we're connected. it could be in > > a loca

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2009-04-15 Thread Petri Damstén
> On 2009-04-14 18:59:59, Aaron Seigo wrote: > > other than a couple of code style comments, and that i can't test it with a > > gps for you either :/, my only question/concern is that it's doing look ups > > on the internet without checking to see if we're connected. it could be in > > a loca

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2009-04-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/592/#review923 --- other than a couple of code style comments, and that i can't test it wit

Review Request: Add city and country resolution to GPS geolocation data using geonames.

2009-04-14 Thread Andrew Coles
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/592/ --- Review request for Plasma. Summary --- Yesterday, I proposed a patch for usi