Re: Review Request: Add call action to contact runner

2010-10-17 Thread Bart Visscher
> On 2010-10-12 20:13:41, Marco Martin wrote: > > too bad there isn't a check in akonadi for the application existence, but > > if the action still "does" something it's ok can someone commit this, i don't have commit access - Bart ---

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/ --- (Updated 2010-10-12 21:13:20.641432) Review request for Plasma. Changes --

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and yo

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and yo

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/#review8100 --- Ship it! too bad there isn't a check in akonadi for the applicati

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and yo

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough There is no function to check in Akonadi. But it is still useful because it displays the number and you can dial it with another phone.

Re: Review Request: Add call action to contact runner

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/#review8085 --- sounds good, you should check if a phone application is available

Review Request: Add call action to contact runner

2010-10-12 Thread Bart Visscher
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/ --- Review request for Plasma. Summary --- When a contact has a phonenumber