Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-19 Thread Marco Martin
On Wednesday 19 August 2009, Shantanu Tushar Jha wrote: > Should this be backported? I really get confused when backporting is > concerned. nah, i don't think so, quite a big patch and too much of a "feature" :) > On Wed, Aug 19, 2009 at 8:40 PM, Marco Martin wrote: > > -

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-19 Thread Shantanu Tushar Jha
Should this be backported? I really get confused when backporting is concerned. On Wed, Aug 19, 2009 at 8:40 PM, Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1329/#

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1329/#review2085 --- Ship it! yes, to me looks fine, go for it - Marco On 2009-08-19 12

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-19 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1329/ --- (Updated 2009-08-19 12:52:00.318912) Review request for Plasma. Changes --

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-15 Thread Shantanu Tushar Jha
> On 2009-08-15 18:58:52, Artur de Souza (MoRpHeUz) wrote: > > Why it doesn't make sense for a non sorted folder view ? Even if the items > > are not sorted, there is a "first item" and a "last item"... > > Marco Martin wrote: > agree Ok, so If in a unsorted view, HOME moves to the upper-l

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1329/#review2037 --- Ship it! to me looks good, i think it should work even when is not so

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-15 Thread Marco Martin
> On 2009-08-15 18:58:52, Artur de Souza (MoRpHeUz) wrote: > > Why it doesn't make sense for a non sorted folder view ? Even if the items > > are not sorted, there is a "first item" and a "last item"... agree - Marco --- This is an aut

Re: Review Request: Add HOME and END key navigation to folderview applet

2009-08-15 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1329/#review2035 --- Why it doesn't make sense for a non sorted folder view ? Even if the i

Review Request: Add HOME and END key navigation to folderview applet

2009-08-15 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1329/ --- Review request for Plasma. Summary --- This adds navigation support using t