Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread wilderkde
> On 2009-05-13 11:42:07, Aaron Seigo wrote: > > woh! =) - wilder --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/#review1117 -

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/#review1117 --- Ship it! - Aaron On 2009-05-13 10:52:19, Ryan Bitanga wrote: > > --

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 10:52:19.305291) Review request for Plasma. Changes ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/#review1114 --- one small tweak to the api and then i think this can go in; note that w

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 10:17:27.601695) Review request for Plasma. Changes ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 10:11:27.207850) Review request for Plasma. Changes ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Aaron Seigo
> On 2009-05-13 08:41:21, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/runnermanager.cpp, lines 345-348 > > > > > > if this became d->context->run(match), which i think makes sense since > > match belongs to the context

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
> On 2009-05-13 08:41:21, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/runnermanager.cpp, lines 345-348 > > > > > > if this became d->context->run(match), which i think makes sense since > > match belongs to the context

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/#review1107 --- the idea is sound, but i think a save(KConfigGroup &group), restore(KC

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 07:13:18.590840) Review request for Plasma. Summary (update

Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- Review request for Plasma. Summary --- This enables adaptive search for KRun