Re: proper use of QFlags

2017-04-15 Thread René J . V . Bertin
Marco Martin wrote: > can you do a phab review about it? https://phabricator.kde.org/D5470

Re: proper use of QFlags

2017-04-15 Thread René J . V . Bertin
Marco Martin wrote: >> Am I right that the argument `QFlags state` should simply be `State >> state`? > > can you do a phab review about it? Of course, but that seemed a bit overkill if this is an evident error, or if ultimately the runtime behaviour remains the same. I understand from a diago

Re: proper use of QFlags

2017-04-14 Thread David Edmundson
>Am I right that the argument `QFlags state` should simply be `State state`? Yes.

Re: proper use of QFlags

2017-04-14 Thread Marco Martin
On Friday 14 April 2017 08:46:20 René J.V. Bertin wrote: > Hi, > > The QtCurve style fails to build against Qt 5.9.0: it triggers a > compile-time assert in the QFlags class on the function below. > > Am I right that the argument `QFlags state` should simply be `State > state`? can you do a phab