Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-08 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated March 8, 2017, 6:43 p.m.) Status -- This change has been ma

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/#review102764 --- Ship it! Ship It! - David Edmundson On March 8, 2017,

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Leslie Zhai
> On 三月 7, 2017, 7:45 p.m., Kai Uwe Broulik wrote: > > applets/appmenu/lib/appmenuapplet.cpp, line 167 > > > > > > Prefer !ctx instead of comparing with nullptr > > > > Also, could you move the check up

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated 三月 8, 2017, 10:17 a.m.) Review request for Plasma, Kai Uwe Broul

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/#review102749 --- applets/appmenu/lib/appmenuapplet.cpp (line 167)