Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127494/ --- (Updated March 26, 2016, 3:15 p.m.) Status -- This change has been m

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127494/#review94018 --- Ship it! This makes sense, and is cleaner. We'll see late

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > > > > > mmm. But is it not rather a qtc bug that states are set in an > > inconsistent manner between widg

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127494/ --- (Updated March 26, 2016, 10:41 a.m.) Review request for Plasma and Hugo P

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread David Rosca
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > > > > > mmm. But is it not rather a qtc bug that states are set in an > > inconsistent manner between widg

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > > > > > mmm. But is it not rather a qtc bug that states are set in an > > inconsistent manner between widg

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread David Rosca
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > > > > > mmm. But is it not rather a qtc bug that states are set in an > > inconsistent manner between widg

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > > > > > mmm. But is it not rather a qtc bug that states are set in an > > inconsistent manner between widg

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127494/#review94012 --- kstyle/breezestyle.cpp (line 3388)