Re: Review Request 126994: Drop usage of Qt4Support

2016-02-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/ --- (Updated Feb. 9, 2016, 3:34 a.m.) Status -- This change has been mar

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92184 --- Ship it! - David Edmundson On Feb. 8, 2016, 2 a.m., Alei

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/ --- (Updated Feb. 8, 2016, 3 a.m.) Review request for Plasma and René J.V. Be

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-07 Thread Aleix Pol Gonzalez
> On Feb. 6, 2016, 12:17 a.m., David Edmundson wrote: > > dataengines/CMakeLists.txt, line 30 > > > > > > ? It's not being used by us, I thought maybe we can remove it instead of dropping Qt4 support there. Thi

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-07 Thread Aleix Pol Gonzalez
> On Feb. 5, 2016, 9:41 p.m., René J.V. Bertin wrote: > > drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp, lines 845-849 > > > > > > I just pushed that other RR you mentioned, but shouldn't that be

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92133 --- components/shellprivate/widgetexplorer/kcategorizeditemsview

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92108 --- dataengines/CMakeLists.txt (line 30)

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-05 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92106 --- I suppose that getting rid of KDELibs4Support isn't a bad thi

Re: Review Request 126994: Drop usage of Qt4Support

2016-02-05 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92105 --- drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cp