Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-02-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126906/ --- (Updated Feb. 1, 2016, 8:44 a.m.) Status -- This change has been mar

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-02-01 Thread Martin Gräßlin
> On Jan. 27, 2016, 6:22 p.m., Thomas Lübking wrote: > > effects/blur/blur.cpp, line 474 > > > > > > Did you try the behavior on a varying scene? > > > > Generating mipmaps isn't exactly cheap and linear

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-01-28 Thread Martin Gräßlin
> On Jan. 27, 2016, 6:22 p.m., Thomas Lübking wrote: > > effects/blur/blur.cpp, line 474 > > > > > > Did you try the behavior on a varying scene? > > > > Generating mipmaps isn't exactly cheap and linear

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-01-28 Thread Thomas Lübking
> On Jan. 27, 2016, 5:22 p.m., Thomas Lübking wrote: > > effects/blur/blur.cpp, line 474 > > > > > > Did you try the behavior on a varying scene? > > > > Generating mipmaps isn't exactly cheap and linear

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-01-28 Thread Martin Gräßlin
> On Jan. 27, 2016, 6:22 p.m., Thomas Lübking wrote: > > effects/blur/blur.cpp, line 474 > > > > > > Did you try the behavior on a varying scene? > > > > Generating mipmaps isn't exactly cheap and linear

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-01-27 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126906/#review91675 --- effects/blur/blur.cpp (line 446)

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-01-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126906/#review91663 --- Tested, looks good! - Eike Hein On Jan. 27, 2016, 1:24 p.m

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-01-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126906/#review91662 --- ah, so one just sets a blur region as usual, but if the windo