Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/ --- (Updated June 1, 2016, 9:45 a.m.) Status -- This change has been mar

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review96130 --- Ship it! Ship It! - David Edmundson On Nov. 23, 2015, 9

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review92550 --- Ship it! Ship It! - Marco Martin On Nov. 23, 2015, 9:50

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review91200 --- Ping Any help on the QListView alignment stuff? - Kai Uwe B

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

> On Nov. 23, 2015, 11:21 p.m., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture. > > Jonathan Riddel

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

> On Nov. 27, 2015, 2:40 nachm., Jonathan Riddell wrote: > > thanks for working on this, looking good. > > > > why add src/pics/CMakeLists.txt ? I thought the idea was to not install > > into kdm? > > > > remember to accompany this with a commit to plasma-desktop to remove the > > existing av

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

> On Nov. 23, 2015, 11:21 nachm., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture. > > Jonathan Ridd

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88893 --- thanks for working on this, looking good. why add src/pics/CM

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

> On Nov. 23, 2015, 11:21 p.m., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture. it uses accountsser

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

> On Nov. 23, 2015, 11:59 nachm., Aleix Pol Gonzalez wrote: > > File Attachment: Avatar gallery - usermanageravatar2.png > > > > > > Why is this not a grid? O.= That's been like this for ages. I don't really know how QListView works, wh

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88746 --- File Attachment: Avatar gallery - usermanageravatar2.png

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88745 --- The interaction seems fine, but since it's a user setting, the