Re: Review Request 125323: Continue even if script returns errors

2015-10-06 Thread David Edmundson
> On Oct. 6, 2015, 1:30 a.m., Rex Dieter wrote: > > Wrapping this in a subshell effectively makes the source'ing ineffective, > > fyi. Adding the ||: at the end is sufficient. Fixed. thanks for the reminder. Siddartha above said the same thing, but it got a bit lost in the comments. - David

Re: Review Request 125323: Continue even if script returns errors

2015-10-05 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review86400 --- Wrapping this in a subshell effectively makes the source'ing i

Re: Review Request 125323: Continue even if script returns errors

2015-09-28 Thread Siddhartha Sahu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review86067 --- The scripts are being sourced in a subshell, so echo will work

Re: Review Request 125323: Continue even if script returns errors

2015-09-20 Thread Steven Franzen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/ --- (Updated Sept. 20, 2015, 3:59 p.m.) Status -- This change has been m

Re: Review Request 125323: Continue even if script returns errors

2015-09-20 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review85691 --- Ship it! Assuming you tested this with /bin/sh, I'm fine with

Re: Review Request 125323: Continue even if script returns errors

2015-09-20 Thread Steven Franzen
> On Sept. 20, 2015, 1:31 p.m., David Edmundson wrote: > > Thanks > > > > Do you have commit access? Nope, I don't - Steven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#revie

Re: Review Request 125323: Continue even if script returns errors

2015-09-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review85686 --- Ship it! Thanks Do you have commit access? - David Edmundso