Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 2:16 p.m., Martin Gräßlin wrote: > > Ship It! ah, to properly work will also need https://git.reviewboard.kde.org/r/125131/ - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewb

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 2:40 p.m.) Status -- This change has been m

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85378 --- Ship it! Ship It! - Martin Gräßlin On Sept. 14, 2015, 3:19

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 12:43 p.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 436 > > > > > > are you going to do the un-duplications? moved the identical part in a private function

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 1:19 p.m.) Review request for kwin, Plasma and E

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85376 --- The change for findWindow(Surface) looks good. effects/slidi

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 12:11 p.m.) Review request for kwin, Plasma and