Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-04 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/ --- (Updated Sept. 4, 2015, 9:40 p.m.) Status -- This change has been ma

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/#review84825 --- Ship it! Ship It! - Martin Gräßlin On Sept. 4, 2015, 12:05

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-04 Thread Martin Gräßlin
> On Sept. 4, 2015, 8:03 a.m., Martin Gräßlin wrote: > > I'm missing an > > add_subdirectory(Darwin) > > > > otherwise I think the new CMakeLists would ever be found. > > Samuel Gaist wrote: > It's already automatically handled by `add_subdirectory( > ${CMAKE_SYSTEM_NAME} )` > >

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-03 Thread Samuel Gaist
> On Sept. 4, 2015, 6:03 a.m., Martin Gräßlin wrote: > > I'm missing an > > add_subdirectory(Darwin) > > > > otherwise I think the new CMakeLists would ever be found. It's already automatically handled by `add_subdirectory( ${CMAKE_SYSTEM_NAME} )` It's located just under the "SunOS" if - S

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/#review84806 --- I'm missing an add_subdirectory(Darwin) otherwise I think the