Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/ --- (Updated Sept. 2, 2015, 12:43 p.m.) Status -- This change has been m

Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/#review84751 --- Ship it! Looks good autotests/client/test_wayland_blur.cpp

Re: Review Request 125015: Blur protocol in KWayland

> On Sept. 1, 2015, 2:35 p.m., Thomas Lübking wrote: > > src/client/blur.h, line 51 > > > > > > a) Why are those classes QObject? Only for parent/child maintainance? > > > > b) Does it make sense to stash

Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/ --- (Updated Sept. 1, 2015, 2:18 p.m.) Review request for kwin and Plasma.

Re: Review Request 125015: Blur protocol in KWayland

> On Sept. 1, 2015, 2:25 p.m., Martin Gräßlin wrote: > > src/client/blur.h, line 111 > > > > > > what is removeBlur doing? Shouldn't a delete of the Blur object be the > > same? > > Marco Martin wrote: > i

Re: Review Request 125015: Blur protocol in KWayland

> On Sept. 1, 2015, 12:35 nachm., Thomas Lübking wrote: > > src/client/blur.h, line 51 > > > > > > a) Why are those classes QObject? Only for parent/child maintainance? > > > > b) Does it make sense to st

Re: Review Request 125015: Blur protocol in KWayland

> On Sept. 1, 2015, 2:25 p.m., Martin Gräßlin wrote: > > src/client/blur.h, line 111 > > > > > > what is removeBlur doing? Shouldn't a delete of the Blur object be the > > same? > > Marco Martin wrote: > i

Re: Review Request 125015: Blur protocol in KWayland

> On Sept. 1, 2015, 12:25 p.m., Martin Gräßlin wrote: > > src/client/blur.h, line 111 > > > > > > what is removeBlur doing? Shouldn't a delete of the Blur object be the > > same? i just copied the same way Shad

Re: Review Request 125015: Blur protocol in KWayland

> On Sept. 1, 2015, 2:35 p.m., Thomas Lübking wrote: > > src/client/blur.h, line 51 > > > > > > a) Why are those classes QObject? Only for parent/child maintainance? > > > > b) Does it make sense to stash

Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/#review84701 --- src/client/blur.h (line 51)

Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/#review84698 --- Looks really good: didn't find anything in the server to compl