Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/ --- (Updated Feb. 1, 2015, 10:39 p.m.) Status -- This change has been ma

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 27, 2015, 4:25 p.m., Ivan Čukić wrote: > > Ship It! @Xuetian Weng Do you have commit access, or should I push this? - Ivan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/1220

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74835 --- Ship it! Ship It! - Ivan Čukić On Jan. 27, 2015, 4:18 p.m.

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/ --- (Updated Jan. 27, 2015, 4:18 p.m.) Review request for Plasma, Martin Gräß

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 27, 2015, 7:27 a.m., Ivan Čukić wrote: > > src/service/ksmserver/KSMServer.cpp, line 72 > > > > > > Can you add: > > - checking for the environment variable existence (and using it, if not > > empty

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 27, 2015, 8:27 a.m., Ivan Čukić wrote: > > src/service/ksmserver/KSMServer.cpp, line 72 > > > > > > Can you add: > > - checking for the environment variable existence (and using it, if not > > empty

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 27, 2015, 8:27 a.m., Ivan Čukić wrote: > > src/service/ksmserver/KSMServer.cpp, line 72 > > > > > > Can you add: > > - checking for the environment variable existence (and using it, if not > > empty

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74808 --- src/service/ksmserver/KSMServer.cpp

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/ --- (Updated Jan. 27, 2015, 12:23 a.m.) Review request for Plasma, Martin Grä

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74574 --- This looks still wrong to me. The service is still called "org

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74573 --- Looks ok to mee, lets just wait for Martin to chime in just in

Re: Review Request 122065: Fix activity start and stop.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/ --- (Updated Jan. 22, 2015, 11:42 p.m.) Review request for Plasma, Martin Grä