Re: Review Request 119860: hints to disable background in dialogs

2014-08-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/ --- (Updated Aug. 22, 2014, 2:58 p.m.) Status -- This change has been ma

Re: Review Request 119860: hints to disable background in dialogs

2014-08-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/#review65063 --- Ship it! Ship It! - David Edmundson On Aug. 21, 2014, 1:55

Re: Review Request 119860: hints to disable background in dialogs

2014-08-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/ --- (Updated Aug. 21, 2014, 1:55 p.m.) Review request for Plasma and Pier Lui

Re: Review Request 119860: hints to disable background in dialogs

2014-08-21 Thread Marco Martin
> On Aug. 21, 2014, 1:12 p.m., David Edmundson wrote: > > src/plasmaquick/dialog.cpp, line 195 > > > > > > we're now doing this on every resize, is this a big overhead? was already there, but apparently was usel

Re: Review Request 119860: hints to disable background in dialogs

2014-08-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/#review64978 --- src/plasmaquick/dialog.cpp

Re: Review Request 119860: hints to disable background in dialogs

2014-08-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/ --- (Updated Aug. 21, 2014, 1:03 p.m.) Review request for Plasma and Pier Lui

Re: Review Request 119860: hints to disable background in dialogs

2014-08-20 Thread Marco Martin
> On Aug. 20, 2014, 4:56 p.m., Sebastian Kügler wrote: > > src/plasmaquick/dialog.h, line 124 > > > > > > Since the background hint is mutually exclusive (semantically, and in > > the code), wouldn't BackgroundH

Re: Review Request 119860: hints to disable background in dialogs

2014-08-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/#review64918 --- src/plasmaquick/dialog.h