Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60781 --- This review has been submitted with commit fec57bdaa2622efbab

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60780 --- This review has been submitted with commit ac5d3d2f916c0a4611

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/ --- (Updated June 23, 2014, 11:03 a.m.) Status -- This change has been m

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60778 --- Ship it! Ship It! - David Edmundson On June 23, 2014, 10:4

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60777 --- Ship it! Ship It! - Marco Martin On June 23, 2014, 10:47 a

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/ --- (Updated June 23, 2014, 10:47 a.m.) Review request for Plasma and Aaron J

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Marco Martin
> On June 23, 2014, 9:59 a.m., David Edmundson wrote: > > plasma/private/dataengine_p.h, line 110 > > > > > > rename this variable; it's not a timestamp (adding since i did already shipit'd it) Good point, updat

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60768 --- plasma/private/dataengine_p.h

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60764 --- Ship it! Code-wise the patch makes sense to me. I'm also run