Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/#review37144 --- This review has been submitted with commit 0368d7423c98c1b9ffc

Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/ --- (Updated Aug. 5, 2013, 4:41 p.m.) Status -- This change has been mark

Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-29 Thread Sebastian Kügler
> On July 29, 2013, 10:58 a.m., Aaron J. Seigo wrote: > > src/plasma/private/dataengine_p.h, line 37 > > > > > > see above Thanks for the review. I'll merge this branch, and related changes once https://git.revi

Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/#review36732 --- Ship it! other than the args member in the private class which

Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/ --- (Updated July 28, 2013, 11:24 p.m.) Review request for Plasma and Aaron J.

Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/#review36500 --- the QVariantList args is s ugly imho; wish there was a bett