Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-25 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- (Updated June 25, 2013, 2:19 p.m.) Status -- This change has been mar

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-24 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34998 --- Ship it! Ship it! We can do small stuff later too. - Sinny Ku

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-24 Thread Shantanu Tushar
> On June 23, 2013, 3:45 p.m., Sinny Kumari wrote: > > According to me, Playlist icon should toggle. If user have to click on > > playlist button to view playlist, user will expect that clicking once again > > will hide it especially in touch devices. > > > > One more issue, related to https:/

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sujith Haridasan
> On June 23, 2013, 3:45 p.m., Sinny Kumari wrote: > > According to me, Playlist icon should toggle. If user have to click on > > playlist button to view playlist, user will expect that clicking once again > > will hide it especially in touch devices. > > > > One more issue, related to https:/

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
> On June 23, 2013, 3:45 p.m., Sinny Kumari wrote: > > According to me, Playlist icon should toggle. If user have to click on > > playlist button to view playlist, user will expect that clicking once again > > will hide it especially in touch devices. > > > > One more issue, related to https:/

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34911 --- According to me, Playlist icon should toggle. If user have to c

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- (Updated June 23, 2013, 2:26 p.m.) Review request for Plasma, Akshay Ratan

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sujith Haridasan
> On June 23, 2013, 10:32 a.m., Sinny Kumari wrote: > > mediaelements/imageviewer/ImageViewer.qml, line 61 > > > > > > Instead of adding MouseArea to Image element, it should be given to > > outer element FocusSco

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34901 --- Awesome work! Few fixes needed: - Playlist icon in mediacontrol

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- (Updated June 23, 2013, 9:06 a.m.) Review request for Plasma, Akshay Ratan

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34900 --- Pagestack navigation looks very good ! :) However two things m

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34898 --- Ship it! I loved the pagestack navigation. Good job. Didn't fo