Re: Review Request: kickoff-qml: TabBar button width

2012-07-26 Thread Marco Martin
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? > > Greg T wrote: >

Re: Review Request: kickoff-qml: TabBar button width

2012-07-20 Thread Greg T
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? > > Greg T wrote: >

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Marco Martin
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? > > Greg T wrote: >

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Greg T
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? Of course I could do t

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16118 --- If you ask me, i like the "old" view better with the elided tex

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16103 --- thanks, wouldn;t have remembered ;) the changes seems good, bu

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Greg T
> On July 3, 2012, 8:34 a.m., Martin Gräßlin wrote: > > please push it again after Akademy - I doubt that I find the time to > > properly read through it in this week well *push* :) any ideas? - Greg --- This is an automatically genera

Re: Review Request: kickoff-qml: TabBar button width

2012-07-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review15332 --- please push it again after Akademy - I doubt that I find the ti