Re: Review Request: bug fixes for the system-monitor applet

2010-10-01 Thread Aaron Seigo
> On 2010-09-25 08:31:36, Petri Damstén wrote: > > Looks good to me. has it been committed? if not, can you please do so, and mark this as submitted. thanks. - Aaron --- This is an automatically generated e-mail. To reply, visit: http:

Re: Review Request: bug fixes for the system-monitor applet

2010-09-25 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/3950/#review7773 --- Ship it! Looks good to me. - Petri On 2010-05-14 08:21:03, Mic

Re: Review Request: bug fixes for the system-monitor applet

2010-09-24 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/3950/#review7747 --- what is the status of this patch? - Beat On 2010-05-14 08:21:03

Re: Review Request: bug fixes for the system-monitor applet

2010-05-14 Thread Michel Lafon-Puyo
> On 2010-05-12 22:07:10, Aaron Seigo wrote: > > a few minor coments below. the biggest issue now is that with your patch, > > the icon for the drives in the disk monitor appear _below_ the meters > > rather than beside them. are you seeing this as well? Le jeudi 13 mai 2010 14:00:25, Petri Da

Re: Review Request: bug fixes for the system-monitor applet

2010-05-14 Thread Michel Lafon-Puyo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/ --- (Updated 2010-05-14 08:21:03.173916) Review request for Plasma. Changes --

Re: Review Request: bug fixes for the system-monitor applet

2010-05-13 Thread Petri Damstén
On Thu, May 13, 2010 at 1:07 AM, Aaron Seigo wrote: Can't find reviewboard password from my laptop so commenting here... > a few minor coments below. the biggest issue now is that with your patch, the > icon for the drives in the disk monitor appear _below_ the meters rather than > beside them

Re: Review Request: bug fixes for the system-monitor applet

2010-05-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/#review5636 --- a few minor coments below. the biggest issue now is that with your pat

Re: Review Request: bug fixes for the system-monitor applet

2010-05-12 Thread Michel Lafon-Puyo
> On 2010-05-11 17:20:41, Aaron Seigo wrote: > > looks like a good start. i've only read through the code, i haven't > > actually done any testing (have to run to a meeting now, actually ...) but > > i will do so later. there are some comments below, in any case. :) > > > > thanks for the patc

Re: Review Request: bug fixes for the system-monitor applet

2010-05-12 Thread Michel Lafon-Puyo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/ --- (Updated 2010-05-12 08:42:09.284778) Review request for Plasma. Changes --

Re: Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/#review5605 --- looks like a good start. i've only read through the code, i haven't ac

Re: Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/#review5604 --- "Note: I was unable to find any bug reports corresponding to the fixes

Re: Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Michel Lafon-Puyo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/ --- (Updated 2010-05-11 16:25:30.146107) Review request for Plasma. Summary (updat