Re: Review Request: basic activity manager

2010-04-28 Thread Aaron J. Seigo
On April 27, 2010, Chani wrote: > do I really need to bother setting the screen at all? or can I assume it'll > magicallly go to the Right one? it may not always go magically to the Right One(tm), but let's try it out as an assumption and see how well the window manager performs for us. > if I d

Re: Review Request: basic activity manager

2010-04-27 Thread Chani
> > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp > > > again, not sure we want containments really associated too much with > the activity manager. it should be fully self-contained and not need to > know which containment it

Re: Review Request: basic activity manager

2010-04-23 Thread Chani Armitage
> On 2010-04-23 08:20:21, Ivan Cukic wrote: > > First, I'm getting two compilation problems - AbstractIcon and > > AbstractIconList are not in Plasma namespace. > > > > The other thing is that AbstractIcon and AbstractIconList don't have > > PLASMAGENERICSHELL_EXPORT so the linker fails as wel

Re: Review Request: basic activity manager

2010-04-23 Thread Chani Armitage
> On 2010-04-23 16:33:26, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp, > > lines 312-314 > > > > > > does the activity manager really need to care if we don't have a > >

Re: Review Request: basic activity manager

2010-04-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3780/#review5187 --- Ship it! obviously it's a work in progress and has its rough edges, b

Re: Review Request: basic activity manager

2010-04-23 Thread Ivan Cukic
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3780/#review5180 --- First, I'm getting two compilation problems - AbstractIcon and Abstrac