Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1828 --- Looks good :) trunk/KDE/kdebase/workspace/plasma/runners/windows/win

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1825 --- Ship it! i think we may need to hook up the KWindowSystem signals in

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- (Updated 2009-07-28 15:06:18.013103) Review request for Plasma. Changes --

Re: Review Request: Window runner to switch windows and desktops

> On 2009-07-26 19:19:43, Aaron Seigo wrote: > > ok, now the implementation review part of things :) > > > > one thing that is useful to observe about this is that it takes a more > > memory intensive approach, storing the individual icons, window info and > > winid of all available windows, t

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1793 --- ok, now the implementation review part of things :) one thing that is

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1792 --- my only comment is that it would be nice if one could type "close kop"

Re: Review Request: Window runner to switch windows and desktops

> On 2009-07-26 15:44:49, Ryan Bitanga wrote: > > trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp, line > > 129 > > > > > > One of the reasons I worked on multiple action support for KRunner in > > 4.

Re: Review Request: Window runner to switch windows and desktops

> On 2009-07-26 15:44:49, Ryan Bitanga wrote: > > trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp, line > > 129 > > > > > > One of the reasons I worked on multiple action support for KRunner in > > 4.

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1788 --- trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- (Updated 2009-07-26 12:34:22.065536) Review request for Plasma. Changes --

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- (Updated 2009-07-26 10:21:46.864061) Review request for Plasma. Changes --

Re: Review Request: Window runner to switch windows and desktops

> On 2009-07-24 12:06:13, Ryan Bitanga wrote: > > When displaying a matching window, I think it would be better to display > > the icon of the window itself and not a generic icon for all matches just > > like what the windows runner in playground does. > > > > It might also help to make the w

Re: Review Request: Window runner to switch windows and desktops

> On 2009-07-24 12:06:13, Ryan Bitanga wrote: > > When displaying a matching window, I think it would be better to display > > the icon of the window itself and not a generic icon for all matches just > > like what the windows runner in playground does. > > > > It might also help to make the w

Re: Review Request: Window runner to switch windows and desktops

> On 2009-07-24 12:06:13, Ryan Bitanga wrote: > > When displaying a matching window, I think it would be better to display > > the icon of the window itself and not a generic icon for all matches just > > like what the windows runner in playground does. > > > > It might also help to make the w

Re: Review Request: Window runner to switch windows and desktops

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1732 --- When displaying a matching window, I think it would be better to displ