Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-28 Thread Aaron J. Seigo
> On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: > > The button size and the hover appearance is different from the original > > one. The IconButton component was made to keep the look of the buttons > > consistent with the original version of the applet. Do we want to change > > this? > >

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14957 --- This review has been submitted with commit ac8552a15ec5a8881e4

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-21 Thread Viranch Mehta
> On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: > > The button size and the hover appearance is different from the original > > one. The IconButton component was made to keep the look of the buttons > > consistent with the original version of the applet. Do we want to change > > this? > >

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-20 Thread Viranch Mehta
> On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: > > The button size and the hover appearance is different from the original > > one. The IconButton component was made to keep the look of the buttons > > consistent with the original version of the applet. Do we want to change > > this? > >

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-20 Thread David Edmundson
> On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: > > The button size and the hover appearance is different from the original > > one. The IconButton component was made to keep the look of the buttons > > consistent with the original version of the applet. Do we want to change > > this? Val

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-18 Thread Sebastian Kügler
On Monday, June 18, 2012 15:37:30 Viranch Mehta wrote: > The button size and the hover appearance is different from the original one. > The IconButton component was made to keep the look of the buttons > consistent with the original version of the applet. Do we want to change > this? Yes, it shoul

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-18 Thread Viranch Mehta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 --- The button size and the hover appearance is different from the

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-18 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14820 --- Ship it! Ship It! - Aaron J. Seigo On June 17, 2012, 7:52 p