Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-23 Thread Sebastian Kügler
On Tuesday 22 June 2010 13:33:28 Ryan Bitanga wrote: > This patch adds oauth support for the microblog dataengine when used with > twitter. No changes need to be made to the applet. > > Helper functions for signature generation and conversion of http request > parameters to strings were based on q

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
> On 2010-06-22 12:16:32, Marco Martin wrote: > > even if it can be seen as a feature it's pretty important that goes in > > asap, before 4.5 > > btw, looking at the patch they shouldn't, but did you see if doesn't > > interfere with identica? I look at it as more of a bugfix than a feature. T

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/#review6230 --- Ship it! even if it can be seen as a feature it's pretty important th

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/ --- (Updated 2010-06-22 11:47:11.665544) Review request for Plasma. Summary --