Re: Review Request: Some system tray fixes

2010-03-07 Thread Marco Martin
> On 2010-03-07 12:49:13, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp, > > line 86 > > > > > > you are still not deleting the bgstore anywhere > > Andreas Hartmet

Re: Review Request: Some system tray fixes

2010-03-07 Thread Andreas Hartmetz
> On 2010-03-07 12:49:13, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp, > > line 418 > > > > > > are you sure this is not needed anymore? do a separate commit for

Re: Review Request: Some system tray fixes

2010-03-07 Thread Marco Martin
> On 2010-03-07 12:49:13, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp, > > line 418 > > > > > > are you sure this is not needed anymore? do a separate commit for

Re: Review Request: Some system tray fixes

2010-03-07 Thread Andreas Hartmetz
> On 2010-03-07 12:49:13, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp, > > line 86 > > > > > > you are still not deleting the bgstore anywhere Not explicitly. But

Re: Review Request: Some system tray fixes

2010-03-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/#review4399 --- Ship it! yes, that part was obviously not finished. looks almost good

Re: Review Request: Some system tray fixes

2010-03-06 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/ --- (Updated 2010-03-07 00:01:49.016030) Review request for Plasma. Changes --

Re: Review Request: Some system tray fixes

2010-03-06 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/ --- (Updated 2010-03-07 01:16:48.875540) Review request for Plasma. Changes --