Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-08-22 Thread Christian Esken
Am Samstag, 20. August 2011, 14:36:40 schrieb Mark Gaiser: > > > On Aug. 20, 2011, 1:22 a.m., Mark Gaiser wrote: > > > Hi, > > > > > > I was just trying to do the same thing with kmix and wasted ~6 hours on that (or even more) just to find that is was already here but never committed. So how ar

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-08-20 Thread Mark Gaiser
> On Aug. 20, 2011, 1:22 a.m., Mark Gaiser wrote: > > Hi, > > > > I was just trying to do the same thing with kmix and wasted ~6 hours on > > that (or even more) just to find that is was already here but never > > committed. So how are we on this? Can this be committed? > > > > Regards, > > M

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-08-19 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review10358 --- Hi, I was just trying to do the same thing with kmix and wasted

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-04-07 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/ --- (Updated April 7, 2011, 8:40 a.m.) Review request for Plasma and Diego Casel

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-26 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/ --- (Updated March 26, 2011, 12:15 p.m.) Review request for Plasma and Diego Cas

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-17 Thread Diego Casella
> On March 14, 2011, 7:06 p.m., Diego Casella wrote: > > Ok, sorry again for my late reply :( > > Services are working great, however, I think you should refactor the way > > the 'mixer' DataEngine works, because it doesn't completely performs what > > it is supposed to. > > Let me explain bett

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-15 Thread Igor Poboiko
> On March 14, 2011, 7:06 p.m., Diego Casella wrote: > > Ok, sorry again for my late reply :( > > Services are working great, however, I think you should refactor the way > > the 'mixer' DataEngine works, because it doesn't completely performs what > > it is supposed to. > > Let me explain bett

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-15 Thread Diego Casella
> On March 14, 2011, 7:06 p.m., Diego Casella wrote: > > Ok, sorry again for my late reply :( > > Services are working great, however, I think you should refactor the way > > the 'mixer' DataEngine works, because it doesn't completely performs what > > it is supposed to. > > Let me explain bett

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-14 Thread Igor Poboiko
> On March 14, 2011, 7:06 p.m., Diego Casella wrote: > > Ok, sorry again for my late reply :( > > Services are working great, however, I think you should refactor the way > > the 'mixer' DataEngine works, because it doesn't completely performs what > > it is supposed to. > > Let me explain bett

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-14 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review9984 --- Ok, sorry again for my late reply :( Services are working great, h

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-08 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/ --- (Updated March 8, 2011, 7:01 p.m.) Review request for Plasma and Diego Casel

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-08 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review9971 --- Sorry for the late reply Igor, I was kinda busy these days. I've t

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-08 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/ --- (Updated March 8, 2011, 8:38 a.m.) Review request for Plasma and Diego Casel

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-08 Thread Igor Poboiko
> On March 7, 2011, 11:54 p.m., Christian Esken wrote: > > /trunk/KDE/kdemultimedia/kmix/apps/kmix.cpp, line 987 > > > > > > I agree that "mixer->toggleMute(md->id());" was quite ugly, and it is > > good that it was

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-07 Thread Christian Esken
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review9969 --- /trunk/KDE/kdemultimedia/kmix/apps/kmix.cpp

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-07 Thread Luca Beltrame
In data lunedì 7 marzo 2011 08:13:17, Aaron Seigo ha scritto: > i'll leave the review of the kmix parts to the kmix devs, though ... I don't think Christian Esken (KMix maintainer; es...@kde.org) has been included in the review CC. Igor, can you add him? That would ensure a review of the kmix re

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-07 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review9965 --- the DataEngine part looks good now.. nice work :) i'll leave the

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-06 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/ --- (Updated March 6, 2011, 7:24 p.m.) Review request for Plasma and Diego Casel

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Aaron Seigo
> On March 5, 2011, 8:25 a.m., Aaron Seigo wrote: > > "When I request an source for Mixer, it also adds soucres for controls. And > > then when I request source for already available Control, it doesn't react > > anyhow. But when I set "Update every % ms", and click "Reqeust", it works > > fin

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Igor Poboiko
> On March 5, 2011, 8:25 a.m., Aaron Seigo wrote: > > "When I request an source for Mixer, it also adds soucres for controls. And > > then when I request source for already available Control, it doesn't react > > anyhow. But when I set "Update every % ms", and click "Reqeust", it works > > fin

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review9951 --- "When I request an source for Mixer, it also adds soucres for cont