Re: Review Request: QML Lock/logout applet

2012-05-01 Thread Viranch Mehta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104592/#review13257 --- Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed86

Re: Review Request: QML Lock/logout applet

2012-05-01 Thread Viranch Mehta
On Wed, May 2, 2012 at 5:19 AM, Viranch Mehta wrote: > On Tue, May 1, 2012 at 6:25 PM, Marco Martin wrote: > >> it should be merged asap because freeze is on 3rd. can you do it either >> today, >> or i can do it as well? >> > > I just added confirmation dialog for sleep as well, and now i'm mergi

Re: Review Request: QML Lock/logout applet

2012-05-01 Thread Viranch Mehta
On Tue, May 1, 2012 at 6:25 PM, Marco Martin wrote: > it should be merged asap because freeze is on 3rd. can you do it either > today, > or i can do it as well? > I just added confirmation dialog for sleep as well, and now i'm merging the branch. Cheers, Viranch

Re: Review Request: QML Lock/logout applet

2012-05-01 Thread Marco Martin
On Tuesday 01 May 2012, Viranch Mehta wrote: > On Mon, Apr 30, 2012 at 8:16 PM, Marco Martin wrote: > >This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/104592/ > > > > any update on this? > > > > Kai here suggested that we have a KSMServer dial

Re: Review Request: QML Lock/logout applet

2012-04-30 Thread Viranch Mehta
On Mon, Apr 30, 2012 at 8:16 PM, Marco Martin wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104592/ > > any update on this? > > Kai here suggested that we have a KSMServer dialog for sleep/hibernate confirmations. I'm not sure how to ac

Re: Review Request: QML Lock/logout applet

2012-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104592/#review13136 --- any update on this? - Marco Martin On April 13, 2012, 6:18 p

Re: Review Request: QML Lock/logout applet

2012-04-16 Thread Kai Uwe Broulik
> On April 14, 2012, 10:11 p.m., Kai Uwe Broulik wrote: > > Couldn’t we add a "Hibernate" dialog, similar to the confirmation on > > shutdown, i.e that dialog that counts down "Shutting down in 30 seconds" > > with the ability to cancel it? You press Hibernate, and a KSMserver dialog > > (that

Re: Review Request: QML Lock/logout applet

2012-04-15 Thread Viranch Mehta
> On April 14, 2012, 10:11 p.m., Kai Uwe Broulik wrote: > > Couldn’t we add a "Hibernate" dialog, similar to the confirmation on > > shutdown, i.e that dialog that counts down "Shutting down in 30 seconds" > > with the ability to cancel it? You press Hibernate, and a KSMserver dialog > > (that

Re: Review Request: QML Lock/logout applet

2012-04-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104592/#review12448 --- Couldn’t we add a "Hibernate" dialog, similar to the confirmati