Re: Review Request: Kickoff-qml fixes

2012-11-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21398 --- This review has been submitted with commit 7ead86e6621de733f59

Re: Review Request: Kickoff-qml fixes

2012-11-03 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21387 --- Ship it! If kickoff doesn't fade, kickoff-qml shouldn't fade t

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > > > > > Why remove this fade in animation? > > David Edmundson wrote: >

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > > > > > Why remove this fade in animation? Because as one of the other pat

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- Ship it! One issue (inline), otherwise it looks good. plasma