Re: Review Request: KSNI: fix IconThemePath support

2012-12-17 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107702/ --- (Updated Dec. 17, 2012, 12:42 p.m.) Review request for Plasma. Changes -

Re: Review Request: KSNI: fix IconThemePath support

2012-12-17 Thread Harald Sitter
> On Dec. 13, 2012, 2:36 p.m., Marco Martin wrote: > > is a quite big regression so something has definitely to be done yeah... > > looking at this part i'm a bit hesitant about exposing themepath in this > > component, because it would be needed pretty much just there. > > luckily the systray h

Re: Review Request: KSNI: fix IconThemePath support

2012-12-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107702/#review23601 --- This review has been submitted with commit 78cfd7a02fe4e260c5b

Re: Review Request: KSNI: fix IconThemePath support

2012-12-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107702/#review23600 --- This review has been submitted with commit a54f9ec9dbbe7001f5a

Re: Review Request: KSNI: fix IconThemePath support

2012-12-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107702/#review23596 --- Ship it! yep, i think this way is pretty good. i think some cr

Re: Review Request: KSNI: fix IconThemePath support

2012-12-13 Thread Marco Martin
> On Dec. 13, 2012, 2:36 p.m., Marco Martin wrote: > > is a quite big regression so something has definitely to be done yeah... > > looking at this part i'm a bit hesitant about exposing themepath in this > > component, because it would be needed pretty much just there. > > luckily the systray h

Re: Review Request: KSNI: fix IconThemePath support

2012-12-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107703/#review23409 --- is a quite big regression so something has definitely to be don