Re: Review Request: Improve PlasmaComponents.ToolButton layout

2012-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104735/#review12929 --- This review has been submitted with commit ecf7d5090c7e2abbe82

Re: Review Request: Improve PlasmaComponents.ToolButton layout

2012-04-26 Thread Aurélien Gâteau
> On April 26, 2012, 12:15 p.m., Marco Martin wrote: > > i agree that looks better here, but i would use thins only for the > > toolbutton (and not doing a similar thing for pushbuttons) > > > > the reason is in part aestetic (if they are stacked vertically they look > > better if they have th

Re: Review Request: Improve PlasmaComponents.ToolButton layout

2012-04-26 Thread Marco Martin
> On April 26, 2012, 12:15 p.m., Marco Martin wrote: > > i agree that looks better here, but i would use thins only for the > > toolbutton (and not doing a similar thing for pushbuttons) > > > > the reason is in part aestetic (if they are stacked vertically they look > > better if they have th

Re: Review Request: Improve PlasmaComponents.ToolButton layout

2012-04-26 Thread Aurélien Gâteau
> On April 26, 2012, 12:15 p.m., Marco Martin wrote: > > i agree that looks better here, but i would use thins only for the > > toolbutton (and not doing a similar thing for pushbuttons) > > > > the reason is in part aestetic (if they are stacked vertically they look > > better if they have th

Re: Review Request: Improve PlasmaComponents.ToolButton layout

2012-04-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104735/#review12925 --- i agree that looks better here, but i would use thins only for

Re: Review Request: Improve PlasmaComponents.ToolButton layout

2012-04-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104735/#review12924 --- Ship it! Looks much better this way. - Sebastian Kügler On