Re: Review Request: Fix crash in Weather plasma engine on resume from ram

2010-02-10 Thread Aurélien Gâteau
Sebastian Kügler wrote: > On Wednesday 10 February 2010 00:45:58 Aurélien Gâteau wrote: >> http://reviewboard.kde.org/r/2868/ > >> When resuming from ram, Weather engine crashes because it tries to free the >> forecast vector more than one time. The change here ensures one can run >> UKMETIon::res

Re: Review Request: Fix crash in Weather plasma engine on resume from ram

2010-02-10 Thread Sebastian Kügler
On Wednesday 10 February 2010 00:45:58 Aurélien Gâteau wrote: > http://reviewboard.kde.org/r/2868/ > When resuming from ram, Weather engine crashes because it tries to free the > forecast vector more than one time. The change here ensures one can run > UKMETIon::reset() multiple times and one can

Re: Review Request: Fix crash in Weather plasma engine on resume from ram

2010-02-10 Thread Aurélien Gâteau
> On 2010-02-10 00:04:50, Shawn Starr wrote: > > Please commit, the other ions will also suffer this. Thanks for catching > > it. Im puzzled why its calling destructor twice though. I doubt the destructor is called twice. What might happen is reset() being called and then the destructor, or re

Re: Review Request: Fix crash in Weather plasma engine on resume from ram

2010-02-09 Thread Shawn Starr
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2868/#review4115 --- Ship it! Please commit, the other ions will also suffer this. Thanks