Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Aaron J. Seigo
> On Jan. 7, 2013, 10:59 a.m., Aaron J. Seigo wrote: > > wouldn't it make more sense to simply use the Theme QML element from > > PlasmaCore components? > > Marco Martin wrote: > yes, either that or if org.kde.plasma.core is imported, a global "theme" > element is already registered, so th

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Marco Martin
> On Jan. 7, 2013, 10:59 a.m., Aaron J. Seigo wrote: > > wouldn't it make more sense to simply use the Theme QML element from > > PlasmaCore components? yes, either that or if org.kde.plasma.core is imported, a global "theme" element is already registered, so there isn't even risk of instancia

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105761/#review24888 --- wouldn't it make more sense to simply use the Theme QML element

Re: Review Request: Expose default Plasma theme to QML based KSplash

2012-12-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105761/ --- (Updated Dec. 19, 2012, 6:30 p.m.) Review request for Plasma and Ivan Čuki