Re: Review Request: Declarative bindings for ToolBox

2012-11-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/#review22273 --- Documentation for this review is now at http://techbase.kde.o

Re: Review Request: Declarative bindings for ToolBox

2012-11-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/#review21522 --- I've redone this patch, submitted a new review request: https:

Re: Review Request: Declarative bindings for ToolBox

2012-11-01 Thread Sebastian Kügler
Hi Marco, Thanks for the review! On Thursday, November 01, 2012 12:29:25 Marco Martin wrote: > I'm quite on the fence with this. > I'm not sure it should be the qml containment to explicitly create the > toolbox, but more: > > the c++ part of the containment scriptengine loads and parses the qml

Re: Review Request: Declarative bindings for ToolBox

2012-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/#review21294 --- I'm quite on the fence with this. I'm not sure it should be the