Re: Review Request: Connect to the correct signal

2011-08-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102173/#review5333 --- Ship it! nice catch.. thanks :) this should be applied to both

Re: Review Request: Connect to the correct signal

2011-08-03 Thread Albert Astals Cid
> On Aug. 2, 2011, 2:53 p.m., Marco Martin wrote: > > good catch > > the slot signature change is ok, the connect syntax shouldn't matter tough > > (ie omitting const in the connect should work and even preferred, see > > http://doc.qt.nokia.com/4.7/signalsandslots.html signature normalization)

Re: Review Request: Connect to the correct signal

2011-08-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102173/#review5317 --- good catch the slot signature change is ok, the connect syntax s