Re: Review Request: Adding history to pastebin plasmoid.

2009-03-31 Thread Artur Souza(MoRpHeUz)
On Tuesday 31 March 2009 12:42:12 Aaron Seigo wrote: > Ship it! > case, the code looks alright... thanks for the patch, please commit. If you do not have commit access, just tell me and I can commit for you =) Cheers, -- Artur Duque de

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-31 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review755 --- Ship it! i'm really not sold on the bottom separator; that should be up

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-31 Thread Danilo Cesar Lemes de Paula
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review753 --- trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-31 Thread Danilo Cesar Lemes de Paula
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- (Updated 2009-03-31 04:38:08.731243) Review request for Plasma. Changes ---

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review744 --- a few minor things, but the patch looks good in general :) trunk/KDE/k

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-30 Thread Danilo Cesar Lemes de Paula
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- (Updated 2009-03-30 12:35:21.706314) Review request for Plasma. Changes ---

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-30 Thread Danilo Cesar Lemes de Paula
> On 2009-03-30 12:06:16, Danilo Cesar Lemes de Paula wrote: > > Maybe the logic between lines 564 and 580 could be replaced by a > > QSignalmapper. I will work on that. Done! See diff r_2! - Danilo Cesar --- This is an automatically g

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-30 Thread Danilo Cesar Lemes de Paula
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- (Updated 2009-03-30 12:27:02.315631) Review request for Plasma. Changes ---

Re: Review Request: Adding history to pastebin plasmoid.

2009-03-30 Thread Danilo Cesar Lemes de Paula
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review739 --- Maybe the logic between lines 564 and 580 could be replaced by a QSignal